-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style guide update #940
base: master
Are you sure you want to change the base?
style guide update #940
Conversation
Hey thanks for opening this PR. The headline hierarchy still looks broken to me:
Apologies for sending you on a wild goose chase here—I'll buy you a thank coffee if you make it to PyCon next year ;-) It's going to be great to get this sorted out because I suspect this sort inconsistency also makes it harder on readers using accessibility tools like screen readers. So your help is very much appreciated. |
No problem, all good. |
I think the terminology here is confusing (chapters, pages, sections). What's the difference between a chapter and a page?
I would prefer something like this
Also, maybe add a note like "Note: Each .rst file should start with a Level 1 heading." |
You make some valid points, when I first looked at it, I wasn't just sure if the chapter would encompass more pages, that later would be assembled into the chapter, like parts of a page. About the examples, could be anything also, I guess the author was just trying to be funny when he wrote those. Your note suggestion is right on point, I mean, you would think that it is obvious that people should use from top down, and never starting anywhere in the middle. From your note precaution, I think we should also have a similar one for mergers, to check the commit against the style guide before merging. Like a fail safe. I guess we could hear some more thoughts before we do any more changes. |
@daniel-demelo @dbader I like his examples the best
|
So, I update the style guide a little bit.
The headings section more specifically.
No more tilde headings, since it was breaking the rendering.
Sphinx reStructuredText Primer is used as baseline for the headings formats.
I also added a Blank lines section
Hopefully no one will be offended by the changes :)
Otherwise let me know and we can work on it