Skip to content

fix(reference): missing parameter in hydrateRoot #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix(reference): missing parameter in hydrateRoot #7724

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7306e0f
fix(reference): missing parameter in hydrateRoot
Kafuu-Chinocya Apr 7, 2025
2250a65
fix: highlights line mismatch
Kafuu-Chinocya Apr 9, 2025
6533158
Merge branch 'reactjs:main' into patch-1
Kafuu-Chinocya Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/content/reference/react-dom/client/hydrateRoot.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,12 +378,13 @@ It is uncommon to call [`root.render`](#root-render) on a hydrated root. Usually

By default, React will log all errors to the console. To implement your own error reporting, you can provide the optional error handler root options `onUncaughtError`, `onCaughtError` and `onRecoverableError`:

```js [[1, 6, "onCaughtError"], [2, 6, "error", 1], [3, 6, "errorInfo"], [4, 10, "componentStack", 15]]
```js [[1, 7, "onCaughtError"], [2, 7, "error", 1], [3, 7, "errorInfo"], [4, 11, "componentStack", 15]]
import { hydrateRoot } from "react-dom/client";
import App from "./App.js";
import { reportCaughtError } from "./reportError";

const container = document.getElementById("root");
const root = hydrateRoot(container, {
const root = hydrateRoot(container, <App />, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch but this causes a crash now:
Screenshot 2025-04-08 at 9 34 43 AM

This happens because the lines listed on 381 are now off by one. Can you update it so it still highlights like this:
Screenshot 2025-04-08 at 9 37 35 AM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Och! Thank for the catch, Let me fix it.

onCaughtError: (error, errorInfo) => {
if (error.message !== "Known error") {
reportCaughtError({
Expand Down