Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forwardRef references from Manipulating the Dom with Refs page #7475

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

dixita0607
Copy link
Contributor

@dixita0607 dixita0607 commented Feb 4, 2025

This PR removes references of forwardRef from the Recap and Challenges section of the page Manipulating the DOM with Refs

Resolves: #7426, #7350, #7470

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 10:51am
react-dev ✅ Ready (Inspect) Visit Preview Feb 4, 2025 10:51am

@facebook-github-bot
Copy link
Collaborator

Hi @dixita0607!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link

github-actions bot commented Feb 4, 2025

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@dixita0607 dixita0607 changed the title Remove forwardRef references from Escape Hatches documentation Remove forwardRef references from Manipulating the Dom with Refs page Feb 4, 2025
@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@erasmoh
Copy link
Contributor

erasmoh commented Feb 19, 2025

This could be reviewed and approved as well, it looks clean and simple IMO @mattcarrollcode.

@gaearon gaearon merged commit 383b389 into reactjs:main Feb 19, 2025
10 checks passed
@dixita0607
Copy link
Contributor Author

dixita0607 commented Feb 20, 2025

@erasmoh @mattcarrollcode
#7391 seems a duplicate.

@dixita0607 dixita0607 deleted the remove-forwardref-references branch February 20, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants