Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ios build with use_frameworks static #771

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-countries-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-native-documents/picker": patch
---

fix: enable ios build with use_frameworks static
8 changes: 7 additions & 1 deletion packages/document-picker/ios/RNDocumentPicker.mm
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,13 @@
#import "RCTConvert+RNDocumentPicker.h"
// this header file is generated by Xcode: https://developer.apple.com/documentation/swift/importing-swift-into-objective-c
// if it cannot be found, try cleaning the build folder and Xcode derived data folder
#import "react_native_document_picker-Swift.h"
#if __has_include("react-native-document-picker-Swift.h")
#import "react-native-document-picker-Swift.h"
#else
// When using use_frameworks! :linkage => :static in Podfile
#import <react_native_document_picker/react_native_document_picker-Swift.h>
#endif

// for UIModalPresentationStyle conversion
// remove after https://github.com/facebook/react-native/commit/2d547a3252b328251e49dabfeec85f8d46c85411 is released
#import <React/RCTModalHostViewManager.h>
Expand Down
Loading