fix: dismiss android datepicker dialog upon unmount #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the behavior of the android datetimepickers more in line with other controlled components in react, where unmounting the component actually dismisses the ui widget as well. Co-authored-by: Stian Jensen <[email protected]>
|
@vonovak I think we can add docs for |
|
@luancurti in order to expose that as the public api, we'd need to expose a bunch of other things as well, and I think it'll be better to leave that for another PR. |
vonovak
pushed a commit
that referenced
this pull request
Nov 17, 2020
## [3.0.5](v3.0.4...v3.0.5) (2020-11-17) ### Bug Fixes * dismiss android datepicker dialog upon unmount ([#337](#337)) ([62abaff](62abaff))
|
🎉 This PR is included in version 3.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
this replaces #326 because the author did not allow to push into his branch
I figured it was easier to do this separately than by reviews
original description:
I also think it might be useful to have a way to dismiss android dialogs from JS and this will expose that possibility. The api will be documented later after we change the api of the android picker to an imperative one, as outlined in #327 (comment)
Test Plan
run demo app, click the "Show and dismiss picker!" button
What's required for testing (prerequisites)?
What are the steps to reproduce (after prerequisites)?
Compatibility
Checklist
README.mdexample/App.js)