Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macCatalyst): assume a provided UDID is valid #2642

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(macCatalyst): assume a provided UDID is valid #2642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/cli-platform-apple/src/commands/runCommand/createRun.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,22 @@ const createRun =
}

if (args.udid) {
const device = devices.find((d) => d.udid === args.udid);
let device = devices.find((d) => d.udid === args.udid);
if (!device) {
return logger.error(
`Could not find a device with udid: "${chalk.bold(
args.udid,
)}". ${printFoundDevices(devices)}`,
// On arm64 machines, the catalyst UDID returned by 'xcrun xctrace list devices' is not correct
// xcodebuild will return an error indicating the UDID is unknown and offering a different one
// you may obtain it by running xcodebuild with the UDID you think works then parse out the other one from the returned error:
// CATALYST_DESTINATION=$(xcodebuild -workspace ios/rnfbdemo.xcworkspace -configuration Debug -scheme rnfbdemo -destination id=7153382A-C92B-5798-BEA3-D82D195F25F8 2>&1|grep macOS|grep Catalyst|head -1 |cut -d':' -f5 |cut -d' ' -f1)
//
// How to handle the incorrect catalyst UDID?
// Assume if a UDID is specified, the user knows what they are doing.
// Use the given UDID and force the type, so "catalyst" will launch the app correctly
device = {name: 'unknown', udid: args.udid, type: 'catalyst'};
logger.warn(
`Could not find a device with udid: "${chalk.bold(args.udid)}".`,
);
logger.warn(
'Running with provided udid anyway, and type "catalyst". \'xcodebuild\' command may return error.',
);
}
if (device.type === 'simulator') {
Expand Down
Loading