Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: Delete rawBody handling on /symbolicate endpoint #2637

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Mar 28, 2025

Summary

This removes a longstanding hack that covered for a lack of JSON body parsing in Metro's /symbolicate endpoint. We're now resolving this in facebook/metro#1475 — meaning this can be removed from CLI.

Relevant changes:

Breaking: CLI will no longer intercept and populate req.rawBody on /symbolicate requests. Clients MUST send the header 'Content-Type': 'application/json'.

Test Plan

  • Build this repo via yarn build.
  • Link @react-native-community/cli-tools and @react-native-community/cli-server-api into a local checkout of react-native via yarn link.
  • Open RNTester, modified to throw an error on launch.

TODO

Checklist

  • Documentation is up to date.
  • Follows commit message convention described in CONTRIBUTING.md.
  • For functional changes, my test plan has linked these CLI changes into a local react-native checkout (instructions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant