Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (doctor): update Java version range to be strictly 11-18 #1940

Merged

Conversation

tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented May 17, 2023

Summary:

Updated Java version check in versionRanges to be strictly [11 - 18] (i.e. 19 is not supported).

Part of #1936

Test Plan:

Updated tests and run yarn test

@adamTrz
Copy link
Collaborator

adamTrz commented May 19, 2023

Hi @tarunrajput
Mind fixing failing test? :)

@adamTrz adamTrz merged commit c142d6b into react-native-community:main May 19, 2023
@arushikesarwani94
Copy link
Contributor

@tarunrajput Just out of curiosity, did you confirm the behavior of RN with Java 19 and onwards ? Or what are the errors in that case, maybe something that can be added to the task list as well later.

@tarunrajput
Copy link
Contributor Author

@arushikesarwani94, I did try to build with jdk19 and it worked fine on both old and new arch. However, Gradle is not fully compatible with jdk20 yet because Kotlin lacks support for it.
@cortinico may have more accurate information on this

@cortinico
Copy link
Member

@cortinico may have more accurate information on this

I didn't have the time to try building on JDK 19 yet, but I'm not aware of any incompatibilities at the moment. Thanks for testing, I'll give it a try in the next days and perhaps we can update the range to include 19 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants