address feedbacks

react-native-community · Sep 20, 2023 · 8571afa · 8571afa
1 parent b3c0e94
commit 8571afa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts b/packages/cli-doctor/src/tools/healthchecks/__tests__/dependencies.test.ts
@@ -36,7 +36,7 @@ describe('dependencies', () => {
     expect(diagnostics.needsToBeFixed).toBe(true);
   });
 
-  it('returns true if dependencies contains an compatible version react native package', async () => {
+  it('warn if dependencies contains an compatible version of react native packages', async () => {
     dependenciesJSON = JSON.stringify({
       name: 'AwesomeProject',
       dependencies: {
@@ -46,6 +46,8 @@ describe('dependencies', () => {
     });
 
     const diagnostics = await dependencies.getDiagnostics(environmentInfo);
-    expect(diagnostics.needsToBeFixed).toBe(true);
+    expect(diagnostics.description).toMatch(
+      '@react-native/codegen is part of React Native and should not be a dependency in your package.json',
+    );
   });
 });
diff --git a/packages/cli-doctor/src/tools/healthchecks/dependencies.ts b/packages/cli-doctor/src/tools/healthchecks/dependencies.ts
@@ -27,7 +27,6 @@ const cliPackages = [
   '@react-native-community/cli-tools',
   '@react-native-community/cli-doctor',
   '@react-native-community/cli-hermes',
-  '@react-native-community/cli-plugin-metro',
   '@react-native-community/cli-clean',
   '@react-native-community/cli-config',
   '@react-native-community/cli-debugger-ui',