Skip to content

Simple Introduction Page #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2015
Merged

Simple Introduction Page #619

merged 2 commits into from
May 8, 2015

Conversation

AlexKVal
Copy link
Member

@AlexKVal AlexKVal commented May 6, 2015

This PR is kind of proposal / draft.
Critics and additions are welcomed.

This work is based on git cherry-picks from Matthew Honnibal PR
syllog1sm/react-bootstrap@3e54374
syllog1sm/react-bootstrap@a7e749e
syllog1sm/react-bootstrap@6f44556

Also added missed space on ComponentsPage.

This PR is successor of #149.

 Contributing Guidelines 
</a>
to see where you can help out.
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather see the contents of this paragraph tag on the home page. Something like:

screen shot 2015-05-06 at 8 44 44 am

Thoughts? I can PR this to your fork to include with this PR if you want or submit a PR for this myself.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed that up on to an active-development-warning branch.

@AlexKVal
Copy link
Member Author

AlexKVal commented May 6, 2015

I like it 👍
I'll remove it from IntroPage and will rewrite code that needs spaces like in your code

Check out the <a 
  href='https://github.com/react-bootstrap/react-bootstrap/wiki#100-roadmap'>1.0.0
  Roadmap</a> and <a

This commit is based on `git cherry-pick`s from Matthew Honnibal PR
syllog1sm@3e54374
syllog1sm@a7e749e
syllog1sm@6f44556
@AlexKVal
Copy link
Member Author

AlexKVal commented May 6, 2015

Re-written.

@AlexKVal
Copy link
Member Author

AlexKVal commented May 7, 2015

/cc @react-bootstrap/collaborators
Do not forget active-development-warning merging 😉

@mtscout6
Copy link
Member

mtscout6 commented May 7, 2015

I just opened a PR for that branch, sorry I forgot to do that.

@aabenoja
Copy link
Member

aabenoja commented May 7, 2015

#625 Is merged.

LGTM

AlexKVal added a commit that referenced this pull request May 8, 2015
Simple Introduction Page
@AlexKVal AlexKVal merged commit a38c6be into react-bootstrap:master May 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants