Skip to content

Custom styles with no validation #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 25, 2015

Conversation

AlexKVal
Copy link
Member

First part of #988

Solves #537 (comment)
partially #543 (comment)
and #306 (comment)

Added document section looks like this:
screen shot 2015-07-21 at 8 24 58 pm

@AlexKVal
Copy link
Member Author

It seems there are some bugs in recently updated dev. dependencies.
(couple hours ago all worked fine)

@AlexKVal
Copy link
Member Author

CI-s restarted. All green.

</Alert>

<h2><Anchor id='custom-styles-with-validation'>With validation</Anchor></h2>
<p>WIP: There is undocumented api that allows adding custom style classes with validation, but it will be changed.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the docs aren't finished yet maybe leave them out for now? Otherwise we will need to finish the whole thing before the next release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all of it, or just second part about WIP ?
The first part seems complete.

@AlexKVal
Copy link
Member Author

Addressed.

}
/>
</div>
<p>But it will warn about invalid <code>bsStyle</code> property</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still feel a bit weird telling ppl to use something that will throw a warning? maybe we should just hold off on any documentation until all the issues around this are addressed?

@AlexKVal
Copy link
Member Author

I just did not get it first time about documenting.
Now it's removed.
Agree. Will document it all at the end of refactoring.

@AlexKVal
Copy link
Member Author

CI-s restarted after #1056
All green now.

@jquense
Copy link
Member

jquense commented Jul 24, 2015

LGTM

1 similar comment
@dozoisch
Copy link
Member

LGTM

AlexKVal added a commit that referenced this pull request Jul 25, 2015
Custom styles with no validation
@AlexKVal AlexKVal merged commit 485b33f into react-bootstrap:master Jul 25, 2015
@AlexKVal AlexKVal deleted the stylesValidation branch July 25, 2015 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants