-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Custom styles with no validation #1034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems there are some bugs in recently updated dev. dependencies. |
CI-s restarted. All green. |
</Alert> | ||
|
||
<h2><Anchor id='custom-styles-with-validation'>With validation</Anchor></h2> | ||
<p>WIP: There is undocumented api that allows adding custom style classes with validation, but it will be changed.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the docs aren't finished yet maybe leave them out for now? Otherwise we will need to finish the whole thing before the next release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all of it, or just second part about WIP
?
The first part seems complete.
Addressed. |
} | ||
/> | ||
</div> | ||
<p>But it will warn about invalid <code>bsStyle</code> property</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel a bit weird telling ppl to use something that will throw a warning? maybe we should just hold off on any documentation until all the issues around this are addressed?
but with validation warning
no public API changes.
a16f17e
to
fd3e509
Compare
I just did not get it first time about documenting. |
CI-s restarted after #1056 |
LGTM |
1 similar comment
LGTM |
Custom styles with no validation
First part of #988
Solves #537 (comment)
partially #543 (comment)
and #306 (comment)
Added document section looks like this:
