Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/callout css override #247

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Fix/callout css override #247

merged 4 commits into from
Feb 10, 2025

Conversation

paanSinghCoder
Copy link
Contributor

Description

  • Feat: Add support for custom leading icon.
  • Fix: style prop overriding width prop.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes, no bug fixes just code improvements)
  • Chore (changes to the build process or auxiliary tools and libraries such as documentation generation)
  • Style (changes that do not affect the meaning of the code (white-space, formatting, etc))
  • Test (adding missing tests or correcting existing tests)
  • Improvement (Improvements to existing code)
  • Other (please specify)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (.mdx files)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
apsara ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 7:34am

paanSinghCoder
paanSinghCoder commented Feb 10, 2025
View reviewed changes
packages/raystack/v1/components/callout/callout.tsx
const style = width ? { width: typeof width === 'number' ? `${width}px` : width } : undefined;
const combinedStyle = {
...style,
...(width && { width: typeof width === 'number' ? `${width}px` : width }),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create a helper function for this later.

@paanSinghCoder paanSinghCoder self-assigned this Feb 10, 2025
@paanSinghCoder paanSinghCoder changed the title Fix/callout css override 5738 Fix/callout css override Feb 10, 2025
@paanSinghCoder paanSinghCoder merged commit 6d7dc88 into main Feb 10, 2025
2 checks passed
@paanSinghCoder paanSinghCoder deleted the fix/callout-css-override-5738 branch February 10, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahakmakharia mahakmakharia mahakmakharia approved these changes

@rsbh rsbh Awaiting requested review from rsbh

Assignees

@paanSinghCoder paanSinghCoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paanSinghCoder @mahakmakharia