[rmodels] Separate GLTF roughness and metallic channels on load #4739
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| for (int y = 0; y < imRoughness.height; y++) { | ||
| Color color = GetImageColor(imMetallicRoughness, x, y); | ||
|
|
||
| Color roughness = (Color) {color.g}; |
Check notice
Code scanning / CodeQL
Unused local variable Note
| Color color = GetImageColor(imMetallicRoughness, x, y); | ||
|
|
||
| Color roughness = (Color) {color.g}; | ||
| Color metallic = (Color) {color.b}; |
Check notice
Code scanning / CodeQL
Unused local variable Note
|
@Not-Nik Nice redesign, I think it's more consistent with raylib this way and will avoid confusions, despite the performance penalty involved... Just a side note, format is not following raylib code conventions, I'm just reviewing it myself now. |
|
@Not-Nik While reviewing the function I got a doubt about the channels used by |
Ah, dammit. I always try to adhere, but my formatter is configured differently, and it messes is up sometimes.
Yes, the spec defines the values to be in these channels. I use the |
Create separate textures for roughness and metallic values when loading GLTF/GLB files. No one interjected, so I just did the implementation of my proposal.
This doesn't break any examples, because the only GLTF+PBR example we have, loads its own texture files manually. I did test this with my own setup, where this creates the same behaviour as if doing the separation in an image editing tool before running, and then loading the textures, after loading the image.
For more info see #4715