-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mcp extension #17978
base: main
Are you sure you want to change the base?
Update mcp extension #17978
Conversation
- Fix env issues - Initial commit
Thank you for your first contribution! 🎉 🔔 @EvanZhouDev you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds environment variable handling improvements to the MCP extension, specifically addressing client initialization failures by properly sourcing shell environment variables.
- Added new
initEnv()
function in/extensions/mcp/src/getProcessedClients.ts
to properly load shell environment variables - Added changelog entry "Fix issue caused by passing
env
inmcp-config.json
" in/extensions/mcp/CHANGELOG.md
- Consider using
showFailureToast
from@raycast/utils
in the catch blocks ofinitEnv()
andgetUserShellPath()
- Recommend wrapping
raycastAiClientInstance.connect()
calls in try-catch blocks for better error handling
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
@radzio LGTM, probably just fix the lint error 😄 |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@EvanZhouDev Consider it done :) |
Description
This PR fixes #17839
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder