Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mcp extension #17978

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update mcp extension #17978

wants to merge 4 commits into from

Conversation

radzio
Copy link

@radzio radzio commented Mar 19, 2025

Description

This PR fixes #17839

Screencast

Checklist

- Fix env issues
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: mcp Issues related to the mcp extension labels Mar 19, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Mar 19, 2025

Thank you for your first contribution! 🎉

🔔 @EvanZhouDev you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

@radzio radzio marked this pull request as ready for review March 19, 2025 14:37
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds environment variable handling improvements to the MCP extension, specifically addressing client initialization failures by properly sourcing shell environment variables.

  • Added new initEnv() function in /extensions/mcp/src/getProcessedClients.ts to properly load shell environment variables
  • Added changelog entry "Fix issue caused by passing env in mcp-config.json" in /extensions/mcp/CHANGELOG.md
  • Consider using showFailureToast from @raycast/utils in the catch blocks of initEnv() and getUserShellPath()
  • Recommend wrapping raycastAiClientInstance.connect() calls in try-catch blocks for better error handling

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

@EvanZhouDev
Copy link
Contributor

@radzio LGTM, probably just fix the lint error 😄

radzio and others added 3 commits March 19, 2025 16:22
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@radzio
Copy link
Author

radzio commented Mar 19, 2025

@radzio LGTM, probably just fix the lint error 😄

@EvanZhouDev Consider it done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: mcp Issues related to the mcp extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Model Context Protocol] ... Get MCP clients failed
3 participants