Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copymoveto extension #17933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snok3r-krk
Copy link

@snok3r-krk snok3r-krk commented Mar 17, 2025

Description

Screencast

Checklist

- fixes before publishing
- Fix linting issues and update contributor name
- updated gitignore to exclude cursor directory
- Add support for hidden folders in directory picker
- Initial commit
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: copymoveto Issues related to the copymoveto extension labels Mar 17, 2025
@raycastbot
Copy link
Collaborator

Thank you for your first contribution! 🎉

🔔 @Mehdi-Hp @pernielsentikaer you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

Due to our current reduced availability, the initial review may take up to 10-15 business days

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds hidden folder support and improves UI elements in the CopyMoveTo extension, allowing users to manage file operations with more control over folder visibility.

  • Added new showHiddenFolders preference to control visibility of hidden folders in directory picker
  • Changed copy icon from Icon.Duplicate to Icon.CopyClipboard for better visual clarity
  • Added new contributor 'snuki' to the extension team
  • Added .cursor to .gitignore for better editor compatibility
  • Properly structured new changelog entry with {PR_MERGE_DATE} template at the top

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Mehdi-Hp
Copy link
Contributor

Mehdi-Hp commented Mar 17, 2025

This seems unnecessary to me as you can just hit cmd+shift+. to show hidden files

@@ -100,6 +114,7 @@ export default function DestinationForm(props: EditDestinationProps) {
allowMultipleSelection={false}
canChooseDirectories={true}
canChooseFiles={false}
showHiddenFiles={preferences.showHiddenFolders}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, use the showHiddenFolders preference. However, this preference is not available in package.json.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the most important part is msising

@pernielsentikaer
Copy link
Collaborator

Could be a nice preference to set - I think it's pretty helpful actually @Mehdi-Hp

Comment on lines +25 to +30
interface Preferences {
fileConflictAction: "prompt" | "overwrite" | "skip" | "rename";
showPath: boolean;
showHiddenFolders: boolean;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interface Preferences {
fileConflictAction: "prompt" | "overwrite" | "skip" | "rename";
showPath: boolean;
showHiddenFolders: boolean;
}

You don't need to manually set preference types as this is autogenerated in raycast-env.d.ts

Comment on lines +17 to +20
interface Preferences {
showHiddenFolders: boolean;
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interface Preferences {
showHiddenFolders: boolean;
}

You don't need to manually set preference types as this is autogenerated in raycast-env.d.ts

@Mehdi-Hp
Copy link
Contributor

Could be a nice preference to set - I think it's pretty helpful actually @Mehdi-Hp

It is helpful, but that's more like a Finder thing. Otherwise, every extension that is using Form.FilePicker should implement this setting.
If you all really think this is useful, I personally prefer a checkbox in the same form, not in the extension's preferences. Or we can even always show the hidden files. But I feel like every Raycast user already knows how to toggle the hidden files' visibility.

@pernielsentikaer
Copy link
Collaborator

The new preference is also being set to required: false, so everything will be working for everyone as it did before this update

@pernielsentikaer pernielsentikaer self-assigned this Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension: copymoveto Issues related to the copymoveto extension extension fix / improvement Label for PRs with extension's fix improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants