-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copymoveto extension #17933
base: main
Are you sure you want to change the base?
Update copymoveto extension #17933
Conversation
- fixes before publishing - Fix linting issues and update contributor name - updated gitignore to exclude cursor directory - Add support for hidden folders in directory picker - Initial commit
Thank you for your first contribution! 🎉 🔔 @Mehdi-Hp @pernielsentikaer you might want to have a look. You can use this guide to learn how to check out the Pull Request locally in order to test it. Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds hidden folder support and improves UI elements in the CopyMoveTo extension, allowing users to manage file operations with more control over folder visibility.
- Added new
showHiddenFolders
preference to control visibility of hidden folders in directory picker - Changed copy icon from
Icon.Duplicate
toIcon.CopyClipboard
for better visual clarity - Added new contributor 'snuki' to the extension team
- Added
.cursor
to.gitignore
for better editor compatibility - Properly structured new changelog entry with
{PR_MERGE_DATE}
template at the top
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
This seems unnecessary to me as you can just hit |
@@ -100,6 +114,7 @@ export default function DestinationForm(props: EditDestinationProps) { | |||
allowMultipleSelection={false} | |||
canChooseDirectories={true} | |||
canChooseFiles={false} | |||
showHiddenFiles={preferences.showHiddenFolders} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, use the showHiddenFolders
preference. However, this preference is not available in package.json.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the most important part is msising
Could be a nice preference to set - I think it's pretty helpful actually @Mehdi-Hp |
interface Preferences { | ||
fileConflictAction: "prompt" | "overwrite" | "skip" | "rename"; | ||
showPath: boolean; | ||
showHiddenFolders: boolean; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface Preferences { | |
fileConflictAction: "prompt" | "overwrite" | "skip" | "rename"; | |
showPath: boolean; | |
showHiddenFolders: boolean; | |
} |
You don't need to manually set preference types as this is autogenerated in raycast-env.d.ts
interface Preferences { | ||
showHiddenFolders: boolean; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interface Preferences { | |
showHiddenFolders: boolean; | |
} |
You don't need to manually set preference types as this is autogenerated in raycast-env.d.ts
It is helpful, but that's more like a Finder thing. Otherwise, every extension that is using |
The new preference is also being set to required: false, so everything will be working for everyone as it did before this update |
Description
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder