Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add salesforce-memo extension #17920

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

suzuki113
Copy link

@suzuki113 suzuki113 commented Mar 17, 2025

Description

Screencast

Checklist

- スタイル修正: Prettierによるコードフォーマット
- 修正: salesforceObjectType設定を必須項目に変更(Salesforce連携に必要なため)
- 改善: unsafeな型キャスト(as unknown as)を型ガード関数による型安全な検証に置換
- 修正: リンク作成失敗時にエラーをスローしてデータの不整合を防止
- 修正: 使用されていないsalesforceService変数を削除
- 修正: MemoDetailコンポーネントでisUploadingステートをUIのローディング表示に使用するよう修正
- スタイル修正: .gitignoreからSwift関連の不要な設定を削除
- ESLint設定を修正: ignorePatterns[\'**/*\']を削除してコード品質チェックを有効化
- UIテキストを日本語から英語に翻訳
@raycastbot raycastbot added the new extension Label for PRs with new extensions label Mar 17, 2025
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

Due to our current reduced availability, the initial review may take up to 10-15 business days

Once the PR is approved and merged, the extension will be available on our Store.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This new Salesforce Memo extension adds functionality to create, manage and sync memos with Salesforce from Raycast. Here's a focused review of the key points:

  • The extension implements proper UTF-8 and Base64 encoding for handling Japanese text in salesforce.ts, showing attention to internationalization
  • Empty memo-to-salesforce.ts file is referenced but missing implementation, this should be removed if unused
  • Several console.log statements throughout the codebase (particularly in view-memos.tsx) should be cleaned up before release
  • The metadata folder for screenshots is missing but required since there are view commands in package.json. Please add screenshots following the Raycast Documentation
  • Duplicate node_modules files with '2' suffix should be removed as they are unnecessary

The implementation is generally solid with good error handling and type safety, but these issues should be addressed before merging.

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

14 file(s) reviewed, 10 comment(s)
Edit PR Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants