-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inbox View in Menu Bar Tasks - #17098 #17899
base: main
Are you sure you want to change the base?
Add Inbox View in Menu Bar Tasks - #17098 #17899
Conversation
Thank you for the update! 🎉 Due to our current reduced availability, the initial review may take up to 10-15 business days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR adds an Inbox view option to the Todoist extension's menu bar tasks, making the view options consistent across the extension.
- Added new
InboxView
component in/extensions/todoist/src/menu-bar.tsx
to display inbox tasks grouped by dates - Added "Inbox" option to view dropdown preferences in
/extensions/todoist/package.json
menu-bar command - Added keyboard shortcut (cmd + i) for quick access to inbox view
- Added proper loading state handling and task count display for inbox view
- Added changelog entry following template format with
{PR_MERGE_DATE}
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
## [Added Inbox View in Menu Bar] - {PR MERGE DATE} | ||
|
||
Added a new option for Inbox in View under Menu Bar Tasks. | ||
|
||
## [Added contributors] - 2025-03-15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: The date '2025-03-15' should be replaced with {PR_MERGE_DATE} to match the template format
## [Added contributors] - 2025-03-15 | |
## [Added contributors] - {PR_MERGE_DATE} |
{ | ||
"title": "Inbox", | ||
"value": "inbox" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: The order of views in the menu bar preferences (Inbox, Today, Filter, Upcoming) doesn't match the order in the home command (Inbox, Today, Upcoming, Completed). Consider keeping the order consistent across the extension.
@jagadeesh-k-2802 Thanks for the PR! The view wasn't working at all for me so I made some changes. Please let me know if everything looks good to you. |
@@ -89,22 +94,24 @@ function MenuBar(props: MenuBarProps) { | |||
return ""; | |||
} | |||
|
|||
if (tasks && !["filter", "inbox"].includes(view)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thomaslombart Don't we want to show task count for inbox? or if you think this is how it should be that's fine.
Description
Added a new View for Inbox under Menu Bar Tasks
#17098
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are located outside the metadata folder if they were not generated with our metadata tool