Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Inbox View in Menu Bar Tasks - #17098 #17899

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jagadeesh-k-2802
Copy link
Contributor

Description

Added a new View for Inbox under Menu Bar Tasks
#17098

Screencast

Screenshot 2025-03-16 at 10 30 55 Screenshot 2025-03-16 at 10 18 23

Checklist

- Add inbox view in menu bar
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: todoist Issues related to the todoist extension OP is contributor The OP of the PR is a contributor of the extension labels Mar 16, 2025
@raycastbot
Copy link
Collaborator

raycastbot commented Mar 16, 2025

Thank you for the update! 🎉

Due to our current reduced availability, the initial review may take up to 10-15 business days

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR adds an Inbox view option to the Todoist extension's menu bar tasks, making the view options consistent across the extension.

  • Added new InboxView component in /extensions/todoist/src/menu-bar.tsx to display inbox tasks grouped by dates
  • Added "Inbox" option to view dropdown preferences in /extensions/todoist/package.json menu-bar command
  • Added keyboard shortcut (cmd + i) for quick access to inbox view
  • Added proper loading state handling and task count display for inbox view
  • Added changelog entry following template format with {PR_MERGE_DATE}

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

## [Added Inbox View in Menu Bar] - {PR MERGE DATE}

Added a new option for Inbox in View under Menu Bar Tasks.

## [Added contributors] - 2025-03-15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: The date '2025-03-15' should be replaced with {PR_MERGE_DATE} to match the template format

Suggested change
## [Added contributors] - 2025-03-15
## [Added contributors] - {PR_MERGE_DATE}

Comment on lines +161 to +164
{
"title": "Inbox",
"value": "inbox"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: The order of views in the menu bar preferences (Inbox, Today, Filter, Upcoming) doesn't match the order in the home command (Inbox, Today, Upcoming, Completed). Consider keeping the order consistent across the extension.

@raycastbot raycastbot added the OP is author The OP of the PR is the author of the extension label Mar 19, 2025
@thomaslombart
Copy link
Collaborator

@jagadeesh-k-2802 Thanks for the PR! The view wasn't working at all for me so I made some changes. Please let me know if everything looks good to you.

@@ -89,22 +94,24 @@ function MenuBar(props: MenuBarProps) {
return "";
}

if (tasks && !["filter", "inbox"].includes(view)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomaslombart Don't we want to show task count for inbox? or if you think this is how it should be that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: todoist Issues related to the todoist extension OP is author The OP of the PR is the author of the extension OP is contributor The OP of the PR is a contributor of the extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants