Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stock-tracker extension - Fix yahoo finance rate limiting #16658

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ericchernuka
Copy link

@ericchernuka ericchernuka commented Jan 28, 2025

Description

  • Fixes the stock tracker extension by adding user agent headers to mimic a browser so that it won't get rate limited.
  • Fixes the throttle prop by providing a default true value as it wasn't adhering to the throttle previously
  • Updates hotkeys from previous TODO's to support cmd+opt+up arrow and cmd+opt-down arrow when moving favorites

Screencast

Checklist

- chore: add contributors
- fix: make modifiers work from todo
- fix: add throttle true to avoid rate limits
- fix: add browser header to trick yahoo api
- feat: update changelog
- chore: add contributors
- fix: make modifiers work from todo
- fix: add throttle true to avoid rate limits
- fix: add browser header to trick yahoo api
@raycastbot raycastbot added extension fix / improvement Label for PRs with extension's fix improvements extension: stock-tracker Issues related to the stock-tracker extension labels Jan 28, 2025
@raycastbot
Copy link
Collaborator

Thank you for your first contribution! 🎉

🔔 @hmarr you might want to have a look.

You can use this guide to learn how to check out the Pull Request locally in order to test it.

You can expect an initial review within five business days.

@ericchernuka ericchernuka changed the title Update stock-tracker extension Fix stock-tracker extension from yahoo finance rate limiting Jan 28, 2025
@ericchernuka ericchernuka changed the title Fix stock-tracker extension from yahoo finance rate limiting Update stock-tracker extension - Fix yahoo finance rate limiting Jan 28, 2025
@pernielsentikaer pernielsentikaer self-assigned this Jan 28, 2025
@pernielsentikaer
Copy link
Collaborator

Looks good to me 🔥

Do you want to check this @hmarr

@hmarr
Copy link
Contributor

hmarr commented Jan 30, 2025

I haven't tried it out, but if adding the header helps with the Yahoo API issues, that's great 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension fix / improvement Label for PRs with extension's fix improvements extension: stock-tracker Issues related to the stock-tracker extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants