Skip to content

[core] split raylet_client into different folder #52288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fscnick
Copy link
Contributor

@fscnick fscnick commented Apr 13, 2025

Why are these changes needed?

This PR address raylet_client part in #51969.

Which puts the stats related target into src/ray/raylet_client.

Related issue number

Closes #52287

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@fscnick fscnick marked this pull request as ready for review April 15, 2025 11:49
@fscnick fscnick requested a review from a team as a code owner April 15, 2025 11:49
@fscnick
Copy link
Contributor Author

fscnick commented Apr 15, 2025

@dentiny PTAL

@jjyao jjyao added the go add ONLY when ready to merge, run all tests label Apr 15, 2025
@jjyao
Copy link
Collaborator

jjyao commented Apr 15, 2025

@fscnick there is a merge conflict.

@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label Apr 16, 2025
@jcotant1 jcotant1 added the core Issues that should be addressed in Ray Core label Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Place bazel targets into separate directories (raylet_client)
4 participants