Revert "Revert "Refactor"" #22
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: golangci-lint | ||
| on: | ||
| push: | ||
| tags: | ||
| - v* | ||
| branches: | ||
| - master | ||
| - main | ||
| pull_request: | ||
| permissions: | ||
| contents: read | ||
| # Optional: allow read access to pull request. Use with `only-new-issues` option. | ||
| # pull-requests: read | ||
| jobs: | ||
| golangci: | ||
| name: lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: 1.19 | ||
| - uses: actions/checkout@v3 | ||
| - name: golangci-lint | ||
| uses: golangci/golangci-lint-action@v3 | ||
| with: | ||
| # Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version | ||
| version: v1.52 | ||
|
|
||
| # Optional: working directory, useful for monorepos | ||
| # working-directory: somedir | ||
|
|
||
| # Optional: golangci-lint command line arguments. | ||
| # args: --issues-exit-code=0 | ||
|
|
||
| # Optional: show only new issues if it's a pull request. The default value is `false`. | ||
| # only-new-issues: true | ||
|
|
||
| # Optional: if set to true then the all caching functionality will be complete disabled, | ||
| # takes precedence over all other caching options. | ||
| # skip-cache: true | ||
|
|
||
| # Optional: if set to true then the action don't cache or restore ~/go/pkg. | ||
| # skip-pkg-cache: true | ||
|
|
||
| # Optional: if set to true then the action don't cache or restore ~/.cache/go-build. | ||
| # skip-build-cache: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| bin | ||
|
There was a problem hiding this comment. [structure] The added lines seem to be related to project configuration and not actual code. Consider removing them from version control to avoid cluttering the repository. |
||
| .idea | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # See https://golangci-lint.run/usage/configuration | ||
| linters: | ||
| # Disable everything by default so upgrades to not include new "default | ||
| # enabled" linters. | ||
| disable-all: true | ||
| # Specifically enable linters we want to use. | ||
| enable: | ||
| - depguard | ||
| - errcheck | ||
| - godot | ||
| - gofmt | ||
| - goimports | ||
| - gosimple | ||
| - govet | ||
| - ineffassign | ||
| - misspell | ||
| - revive | ||
| - staticcheck | ||
| - typecheck | ||
| - unused | ||
|
|
||
| issues: | ||
| exclude-rules: | ||
| # helpers in tests often (rightfully) pass a *testing.T as their first argument | ||
| - path: _test\.go | ||
| text: "context.Context should be the first parameter of a function" | ||
| linters: | ||
| - golint | ||
| # Yes, they are, but it's okay in a test | ||
| - path: _test\.go | ||
| text: "exported func.*returns unexported type.*which can be annoying to use" | ||
| linters: | ||
| - golint | ||
|
|
||
| linters-settings: | ||
| misspell: | ||
| locale: US | ||
| ignore-words: | ||
| - cancelled | ||
| goimports: | ||
| local-prefixes: github.com/ravilushqa/gpt-pullrequest-updater |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| .PHONY: init-tools lint test test-coverage precommit help | ||
|
|
||
| build: | ||
| go build -o bin/description ./cmd/description && \ | ||
| go build -o bin/review ./cmd/review | ||
|
|
||
| # run this once to install tools required for development. | ||
| init-tools: | ||
| cd tools && \ | ||
| go mod tidy && \ | ||
| go mod verify && \ | ||
| go generate -x -tags "tools" | ||
|
|
||
| # run golangci-lint | ||
| lint: init-tools | ||
| ./bin/golangci-lint run --timeout=30m ./... | ||
|
|
||
| # run go test | ||
| test: | ||
| go test -race -count 1 ./... | ||
|
|
||
| # run go test with coverage | ||
| test-coverage: | ||
| go test -race -coverprofile=coverage.txt -covermode=atomic ./... | ||
|
|
||
| # precommit command. run lint, test | ||
| precommit: lint test | ||
|
|
||
| # show help | ||
| help: | ||
| @echo 'Usage:' | ||
| @echo ' make [target]' | ||
| @echo '' | ||
| @echo 'Targets:' | ||
| @awk '/^[a-zA-Z\-\_0-9]+:/ { \ | ||
| helpMessage = match(lastLine, /^# (.*)/); \ | ||
| if (helpMessage) { \ | ||
| helpCommand = substr($$1, 0, index($$1, ":")-1); \ | ||
| helpMessage = substr(lastLine, RSTART + 2, RLENGTH); \ | ||
| printf "\033[36m%-22s\033[0m %s\n", helpCommand,helpMessage; \ | ||
| } \ | ||
| } \ | ||
| { lastLine = $$0 }' $(MAKEFILE_LIST) | ||
|
|
||
| .DEFAULT_GOAL := help |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[bug] Missing newline character at the end of the file.