refactor review #12
Merged
refactor review #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several changes to the
cmd/reviewpackage. Theconfig.gofile has been updated to include options for GitHub and OpenAI tokens, GitHub owner, repo, and pull request number, as well as a test mode option. Themain.gofile has been refactored to extract file processing logic into a separate function and return comments generated from processing files using the OpenAI API. Unused imports and command line arguments have also been removed. Thereview.gofile has been updated to include a new functionprocessFilesto process files and extract reviews from them using OpenAI API. If the review is not good, it creates a new comment on the pull request with the issue description and line number. A new functioncreateCommentshas also been added to create comments on the pull request using GitHub API. Theutils.gofile has been updated to include a function to extract a JSON object from a string input and return it as a Review struct. Theutils_test.gofile has been updated to include a new test functionTest_extractReviewFromStringto parse review strings and return the expectedReviewstruct. Finally, thego.modfile has been updated to includegolang.org/x/oauth2 v0.6.0as a required dependency.Changes
cmd/review/config.goto include options for GitHub and OpenAI tokens, GitHub owner, repo, and pull request number, as well as a test mode option.cmd/review/main.goto extract file processing logic into a separate function and return comments generated from processing files using the OpenAI API. Removed unused imports and command line arguments.cmd/review/review.goto include a new functionprocessFilesto process files and extract reviews from them using OpenAI API. If the review is not good, it creates a new comment on the pull request with the issue description and line number. Added a new functioncreateCommentsto create comments on the pull request using GitHub API.cmd/review/utils.goto include a function to extract a JSON object from a string input and return it as a Review struct.cmd/review/utils_test.goto include a new test functionTest_extractReviewFromStringto parse review strings and return the expectedReviewstruct.go.modto includegolang.org/x/oauth2 v0.6.0as a required dependency.