Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix variable pathname spacing" #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kilograham
Copy link
Contributor

This reverts commit 1abda4c.

That commit changes upstream files that have not themselves been changed, which might be ok if we changed them to what they will be, but the changes are I think majorly heavy-handed

I suspect only variables passed as args to get_filename_component or other functions need to be quoted.

set(FOO ${BAR}) is totally fine.

@kilograham kilograham requested a review from P33M March 22, 2025 17:59
@lurch
Copy link
Contributor

lurch commented Mar 23, 2025

See also "upstream discussions" in raspberrypi/pico-sdk#2349 and FreeRTOS/FreeRTOS-Kernel#1255
And #164 was the PR in this repo that added the commit that's being reverted here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants