Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCC 13 in CUDA 12 conda builds. #347

Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 13, 2025

Description

conda-forge is using GCC 13 for CUDA 12 builds. This PR updates CUDA 12 conda builds to use GCC 13, for alignment.

These PRs should be merged in a specific order, see rapidsai/build-planning#129 for details.

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Jan 13, 2025
Copy link

copy-pr-bot bot commented Jan 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@bdice bdice self-assigned this Jan 13, 2025
@bdice bdice added the DO NOT MERGE Hold off on merging; see PR for details label Jan 13, 2025
@bdice bdice marked this pull request as ready for review January 13, 2025 19:39
@bdice bdice requested a review from a team as a code owner January 13, 2025 19:39
@bdice bdice requested a review from KyleFromNVIDIA January 13, 2025 19:39
@jameslamb jameslamb requested review from jameslamb and removed request for KyleFromNVIDIA January 13, 2025 20:10
@jameslamb
Copy link
Member

check-nightly-ci is failing like this:

Traceback (most recent call last):
  File "/home/runner/work/ucxx/ucxx/shared-actions/check_nightly_success/check-nightly-success/check.py", line 106, in <module>
    main(
  File "/home/runner/work/ucxx/ucxx/shared-actions/check_nightly_success/check-nightly-success/check.py", line 66, in main
    latest_branch = max(latest_success)
                    ^^^^^^^^^^^^^^^^^^^
ValueError: max() iterable argument is empty

(build link)

I'll investigate that right now.

@jameslamb
Copy link
Member

I think this will fix the check-nightly-ci issue: rapidsai/shared-actions#38

@jakirkham
Copy link
Member

Looks like the rest of the CI jobs were waiting. Since the aforementioned PR was merged, went ahead and restarted those CI jobs

@jakirkham
Copy link
Member

One job had an error as it was unable to checkout the PR. Guessing a network error. So restarted it

@jakirkham
Copy link
Member

Looks like CI is now passing! 🥳

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 17, 2025
@bdice
Copy link
Contributor Author

bdice commented Jan 17, 2025

/merge

@rapids-bot rapids-bot bot merged commit 527ed52 into rapidsai:branch-0.42 Jan 17, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants