This repository was archived by the owner on Aug 27, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#7.
See rapidsai/ci-imgs#102 for a description of why I'm proposing this.
In short, I think it's desirable for builds to fail with a big loud error if the expected build args aren't passed through.
e.g. this:
docker-buildx build \ -f ./Dockerfile \ -t rapidsai/miniforge-cuda:local \ .
Should result in