Skip to content
This repository was archived by the owner on Aug 27, 2024. It is now read-only.

make build-arg passing stricter #57

Merged
merged 1 commit into from
Jan 3, 2024
Merged

make build-arg passing stricter #57

merged 1 commit into from
Jan 3, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#7.

  • removes some defaults in ARG statements in the project's Dockerfiles
  • replaces other defaults with placeholder values that make loud errors more likely

See rapidsai/ci-imgs#102 for a description of why I'm proposing this.

In short, I think it's desirable for builds to fail with a big loud error if the expected build args aren't passed through.

e.g. this:

docker-buildx build \
    -f ./Dockerfile \
    -t rapidsai/miniforge-cuda:local \
    .

Should result in

ERROR: failed to solve: nvidia/cuda:notset-base-notset: docker.io/nvidia/cuda:notset-base-notset: not found

@jameslamb jameslamb changed the title WIP: make build-arg passing stricter make build-arg passing stricter Dec 20, 2023
@jameslamb jameslamb marked this pull request as ready for review December 20, 2023 19:22
@jameslamb jameslamb merged commit f727621 into rapidsai:main Jan 3, 2024
@jameslamb jameslamb deleted the stricter-defaults branch January 3, 2024 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants