RSN for conda package legacy labelling
#570
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
gforsyth
force-pushed
the
channel_priority_notice
branch
from
def31c7 to
e20ea8c
Compare
_notices/rsn0042.md
Outdated
|
|
||
| RAPIDS will move certain older conda packages in the `rapidsai` conda channel | ||
| under a new label: `legacy`. These packages will still be available by appending | ||
| `--label legacy` to installation and search commands. |
There was a problem hiding this comment.
I'm a little unclear on this. It looks like --label is used when uploading, but for users to install, they need something like --channel rapidsai --channel rapidsai/label/legacy. Does that sound correct?
There was a problem hiding this comment.
Yup, thanks for catching that @bdice !
Co-authored-by: Bradley Dice <[email protected]>
_notices/rsn0042.md
Outdated
| All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to | ||
| work without any user intervention. | ||
|
|
||
| This change will occur concurrently with the release of RAPIDS `v25.04`. |
There was a problem hiding this comment.
Just checking: We will be able to test strict channel priority in our CI before the 25.04 release, right? I want to be sure we minimize the risk of breaking recent releases (25.02 / 25.04) during this change.
There was a problem hiding this comment.
We'll be able to test 25.02 once all of those packages are released using the same method I tested the previous releases with. Regarding 25.04, we can also release all of those packages, test, then move the selected older packages under the legacy label, or we can move them under the label, see if it works, and then undo the labeling if it breaks.
If 25.02 works, I'd feel confident moving the packages straight to the label for 25.04, and that would let us accurately advertise strict channel priority for the new install instructions.
There was a problem hiding this comment.
That's helpful. What about enabling strict priority in our CI for PR & nightly builds/tests, though? It sounds like you're discussing the user experience that we expect after the release is complete.
There was a problem hiding this comment.
We can't really enable them for CI until we move the older packages under legacy. The conda-metachannel package is quite brittle at this point and I don't think we want that spun up as part of our CI
There was a problem hiding this comment.
Does that mean we will make the legacy label along with the 25.04 release, and then enable strict priority in our CI during development for 25.06?
There was a problem hiding this comment.
We can't really enable them for CI until we move the older packages under
legacy
Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.
Or said another way... if we're saying this -c rapidsai/label/legacy is only necessary for releases before RAPIDS v23.04, then I'd expect to be able to use strict channel priority with RAPIDS 25.04 today.
(sorry if I'm re-litigating things that have already been discussed, feel free to just respond with links to things I should go read)
There was a problem hiding this comment.
You're asking a good question. I think the only confusing part here is timing.
We can't enable strict channel priority until we move "legacy" packages (needed for releases prior to 23.04) to the legacy label. There are packages like datashader that are implicated here.
We plan to move things to the legacy label when 25.04 is released. Then we can enable strict priority in 25.06.
However, there is a path where we enable strict priority gradually in each repo's CI, which I think we could start in 25.04. It just won't work for every repo until after the "legacy" move occurs with the 25.04 release.
There was a problem hiding this comment.
Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.
channel priority doesn't consider versions -- if there is ANY version of a package in a higher priority channel, that is the only channel that gets considered for that package. because we have (especially) a patched version of datashader (although there are other problem packages) in rapidsai, most of our solves won't work because it'll see datashader in rapidsai but the single version in rapidsai won't satisfy the current dependency requirements and the solve will fail.
There was a problem hiding this comment.
ahhhhhhh ok, thank you both for explaining. Ok then this makes sense to me as-is.
Agree with @bdice that it'd be really helpful to try to enable this repo-by-repo within the 25.04 cycle, to hopefully prevent accidental introduction of even more things that complicate the move to strict channel priority. And because it's a solution to the "did not install the package built in CI" problem: rapidsai/build-planning#14 (comment)
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Coming here to review based on @jakirkham 's suggestion in rapidsai/build-planning#14 (comment)
I'm leaving a blocking review because a couple of these have to be fixed (like the RSN number).
Can you also please update this to latest main? There are some new commits there since the last time this was modified.
_notices/rsn0042.md
Outdated
| All RAPIDS conda install commands for RAPIDS versions `v23.04+` will continue to | ||
| work without any user intervention. | ||
|
|
||
| This change will occur concurrently with the release of RAPIDS `v25.04`. |
There was a problem hiding this comment.
We can't really enable them for CI until we move the older packages under
legacy
Why is this? I'd think that in RAPIDS CI for 25.04, the pins like ==25.4.* we have for all RAPIDS packages would be sufficient to allow this.
Or said another way... if we're saying this -c rapidsai/label/legacy is only necessary for releases before RAPIDS v23.04, then I'd expect to be able to use strict channel priority with RAPIDS 25.04 today.
(sorry if I'm re-litigating things that have already been discussed, feel free to just respond with links to things I should go read)
|
Thanks for the suggestions and fixes @jameslamb ! Pushed up all of those and merged in |
RSN for moving select conda packages behind a new
legacylabel concurrent with thev25.04release.I wasn't sure whether to note the
notice_rapids_versionas the version wherethis change takes place (
25.04) or the versions impacted by the change(
<=23.02). I think<=23.02makes more sense and I've written it as such, buthappy to change things around.
xref rapidsai/build-planning#84