Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redundant tagging in workflow page #512

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

ncclementi
Copy link
Contributor

Closes #510

@ncclementi ncclementi requested a review from a team as a code owner February 6, 2025 18:59
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I think we also need to prefix the CSP tags with cloud/.

"aws/ec2",
"aws/sagemaker",
"azure/azure-vm",
"azure/ml",
"gcp/compute-engine",
"gcp/vertex-ai",

@ncclementi
Copy link
Contributor Author

Ready for final review.

Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@jacobtomlinson jacobtomlinson merged commit 27a82cb into rapidsai:main Feb 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix redundant tags in workflows
2 participants