-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codespell to pre-commit configuration #489
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -18,6 +18,16 @@ select = [ | |||||
"B" | ||||||
] | ||||||
|
||||||
[tool.codespell] | ||||||
# note: pre-commit passes explicit lists of files here, which this skip file list doesn't override - | ||||||
# this is only to allow you to run codespell interactively | ||||||
skip = "./.git,./build,./python/_skbuild/,.*egg-info.*,./.mypy_cache,./pyproject.toml,./benchmarks/utilities/cxxopts.hpp" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
This project doesn't have some of these paths... I'm guessing that maybe you just copied this from another repo. Let's please keep it limited to directory that appear in this project. |
||||||
# ignore short words, and typename parameters like OffsetT | ||||||
ignore-regex = "\\b(.{1,4}|[A-Z]\\w*T)\\b" | ||||||
ignore-words-list = "thirdparty,couldn" | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I don't see either |
||||||
builtin = "clear" | ||||||
quiet-level = 3 | ||||||
|
||||||
[tool.ruff.lint.per-file-ignores] | ||||||
"source/examples/**/*.ipynb" = [ | ||||||
# "module level import not at top of cell". | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this
tool.codespell
table to the head of the file, to preserve alphabetical ordering (by table name). This makes it a little easier to navigate the file as it gets bigger.