Remove DeprecationWarnings from MG Uniform Neighbor Sample test #4722
+0
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging in latest This will also let us test whether we fixed issue: rapidsai/shared-workflows#250 |
rlratzel
approved these changes
Nov 21, 2024
BradReesWork
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is Blocked
Originally removing the
with_edge_properties=Truearg should still retain the same behavior since it's a deprecated arg. However, I've been notified that the deprecation process wasn't finished properly because priorities shifted. There's also an effort to add a new sampling C API so this should ideally be solved and merge-able onceuniform_neighbor_sampleis properly migrated.Suggested Changes
This PR removes kwargs for
uniform_neighbor_samplethat are deprecated.