Add tests for Samr::UserProperties #285
Merged
+76
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroSteiner
commented
Mar 14, 2025
Comment on lines
+43
to
+57
| context 'when #user_properties is cleared' do | ||
| before(:each) { subject.user_properties.clear } | ||
|
|
||
| it 'does not include the property_count' do | ||
| expect(subject.property_count?).to be_falsey | ||
| expect(subject.snapshot).to_not include(:property_count) | ||
| end | ||
|
|
||
| it 'does not include the user_properties' do | ||
| expect(subject.user_properties?).to be_falsey | ||
| expect(subject.snapshot).to_not include(:user_properties) | ||
| end | ||
| end |
There was a problem hiding this comment.
This one here highlights the behavior that has been a problem in the past where the state of user_properties needs to be synced properly.
|
|
||
| it 'includes the user_properties' do | ||
| expect(subject.user_properties?).to be_truthy | ||
| expect(subject.snapshot).to include(:user_properties) |
There was a problem hiding this comment.
Same here?
Suggested change
| expect(subject.snapshot).to include(:user_properties) | |
| expect(subject.snapshot).to include(:user_properties) | |
| expect(subject.user_properties).to eq([user_property1, user_property2]) |
zeroSteiner
force-pushed
the
feat/dcerpc/samr/3
branch
from
6b606bd to
f99b469
Compare
cdelafuente-r7
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for
Samr::UserProperties. There are no functional changes, just tests to ensure things continue to consistently work as we intend for them to.Testing