Linux: renable use of process groups #8009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, manually set the process group for the main Electron process to its pid so that we can use it to terminate any processes we spawn as part of extensions. Note that this happens after Electron has started other processes; hence some of the Electron-internal processes will have the old process group. This is not an issue as they will go away once the main process does. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
linux/process-groups
branch
2 times, most recently
from
5f5de3d to
7e37a06
Compare
Check the process group of the target pid when killing it; if it matches the pid (i.e., the process is the leader of its own group), it is safe to kill the whole group instead of just the main process. Signed-off-by: Mark Yen <[email protected]>
mook-as
force-pushed
the
linux/process-groups
branch
from
7e37a06 to
4f391f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code to manually set a process group on Linux only, and to re-enable the use of process groups to terminate processes on shutdown.
Fixes #7653