-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement support for funds data #2041
Conversation
Update readme |
Done. Thanks for reviewing. |
Set df indexes. And some might be better as simple dict. |
I converted data with just 2 columns to dicts and kept the others as DF with the indices set. |
hey @ValueRaider not sure if you've been busy or just missed it so pinging again. thanks. |
Looks good for I would rephrase this:
Then with:
don't discard the original exception. See how |
- adding to scraper a new class FundsData. - Ticker can now reference the data via ticker.funds_data when appropriate. - Add unit tests in test_ticker.py for the funds data
Thanks for reviewing @ValueRaider. I interpreted the part about "don't discard the original exception" as meaning to log the base exception so implemented as such. |
Changes:
FundsData
.ticker.funds_data
when appropriate. When the ticker symbol is not that of a fund's, the code will throw an error when a parameter offunds_data
is called. i.e.yf.Ticker('AAPL').funds_data.description
test_ticker.py
for the funds datatest_ticker.py
asYFChartError
was removed from code in Prices: improve exceptions and logging #2000Resolves:
Sample Code:
Credits to #1784 for the idea