Patch keyError in #2027 #2029
Open
Patch keyError in #2027 #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Fix datetime conversion with mixed timezones when ignore_tz is False
|
That's not the solution. Look at the metadata. |
|
The same information as in the original PR, #2026, can be fetched from the will have the same format as most other stocks for this key. I don't know if Yahoo Finance may give differently formated metadata for the ´'currentTradingPeriod'´ key. |
|
Just add 2 unit tests: one with prepost=False, other with True. Then rebase to dev branch #1084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves ´KeyError´ occurrence in #2027.
Adds Try/Except statement to find keyerror and return to old code if the keyerror is triggered.