Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #244.
Some ETF information was not being pulled, because it was being stored at a different place. After reading #248, #557, and playing around with the URL endpoint, I noticed that the parameter
fundProfile
was not being pulled.This fix simply adds the parameter to the
fetch
method, which will pull the data.Here's the response sample for the contents of
fundProfile
for the VTI ticker:As I mentioned above, this will simply pull the data; at this point, the question would be whether to add or not some feature that handles the data above in any specific way after detecting that a given ticker is an ETF, which I think would just add more complexity to the way data is being handled in this module.
With this fix, calling
ticker.info['feesExpensesInvestment']['annualReportExpenseRatio']
would yield the desired return.