-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For ETFs & Mutual Funds, add fundProfile & fundPerformance details #1159
base: dev
Are you sure you want to change the base?
For ETFs & Mutual Funds, add fundProfile & fundPerformance details #1159
Conversation
This is fine, but we have temporarily frozen |
Sure that works !! |
|
@thirumalairajr The changes should now go into this file: |
@fredrik-corneliusson Sure I will make the changes |
@ValueRaider I have resolved the merge conflicts. |
Code is fine. I've examined An alternative is blacklist those keys with a comment and someone else implement in future. And maybe just add most recent value of each. |
@ValueRaider I can implement the pandas way as I see value in that approach. Adding only the recent value of each might not be useful as this data is consumed with history. But I don't think trailingReturns is a time-series data , the access pattern for this would be mostly key-based lookup for getting 10 year , 5 year returns etc., I can create annual_total_returns, past_quarterly_returns functions to return annualTotalReturns & pastQuarterlyReturns data as dataframe. Shall I start working on it? |
Ah you're right on trailingReturns, I must have got mixed up. Go ahead with Pandas. |
Abandoned. Anyone want to take over and finish? |
I'll take it over and track it at #2040 |
Hi,
This change will add support for showing fundProfile & fundPerformance of ETFs and Mutual Funds.
fundProfile will add support for useful fields like
fundPerfomance will add support for useful fields like