Watch app embedded engine initializers #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
gmcgibbon
force-pushed
the
booted-load-hook
branch
3 times, most recently
from
3dbbbb3
to
7f053a7
Compare
gmcgibbon
force-pushed
the
booted-load-hook
branch
6 times, most recently
from
b06ccef
to
6fc5c12
Compare
This will allow embedded engine initializers to reload the application when changed. Previously, the server would have to be reloaded manually. Co-Authored-By: Gannon McGibbon <[email protected]>
gmcgibbon
force-pushed
the
booted-load-hook
branch
from
6fc5c12
to
6c60916
Compare
gmcgibbon
changed the title
spring_booted ActiveSupport load hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to configure spring's file watcher to watch additional files when booting my app. Specifically, I want to update Rails to watch the
config/initializersdirectory of engines defined within the application, so that spring will automatically reload when updating those initializers like it does with the rootconfig/initializers.By iterating engine descendants we can watch paths that intersect with
Rails.root.