Add lifecycle hooks to Dispatcher and Scheduler #486
Merged
+37
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm switching over to Rails Semantic Logger and for that to work
with forking code it requires a post fork action.
With this change, all 4 process types have start and stop hooks and it becomes
possible to do on_*_start { post_fork_action } and on_*_stop { pre_stop_action }
hms
force-pushed
the
add_lifecycle_hooks
branch
from
01907a7 to
0d66e3d
Compare
|
Hey @hms, sorry for the delay on this one! Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm switching over to Rails Semantic Logger and for that to work with forking code it requires a post fork action.
With this change, all 4 process types have start and stop hooks and it becomes possible to do on_start { post_fork_action } and on_stop { pre_stop_action }