When resolving sourcemap URL, ignore leading directory

These may be outputted by esbuild when using its `--public-path` option
rails · Aug 27, 2023 · ed772e8 · ed772e8
1 parent 85e8ff6
commit ed772e8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/lib/propshaft/compiler/source_mapping_urls.rb b/lib/propshaft/compiler/source_mapping_urls.rb
@@ -3,7 +3,7 @@
 require "propshaft/compiler"
 
 class Propshaft::Compiler::SourceMappingUrls < Propshaft::Compiler
-  SOURCE_MAPPING_PATTERN = %r{^(//|/\*)# sourceMappingURL=(.+\.map)}
+  SOURCE_MAPPING_PATTERN = %r{^(//|/\*)# sourceMappingURL=(?:.*\/)?(.*\.map)}
 
   def compile(logical_path, input)
     input.gsub(SOURCE_MAPPING_PATTERN) { source_mapping_url(asset_path($2, logical_path), $1) }

diff --git a/test/fixtures/assets/mapped/prefixed-source.js b/test/fixtures/assets/mapped/prefixed-source.js
diff --git a/test/fixtures/assets/mapped/prefixed-source.js.map b/test/fixtures/assets/mapped/prefixed-source.js.map
diff --git a/test/propshaft/compiler/source_mapping_urls_test.rb b/test/propshaft/compiler/source_mapping_urls_test.rb
@@ -25,6 +25,11 @@ class Propshaft::Compiler::SourceMappingUrlsTest < ActiveSupport::TestCase
                  compile_asset(find_asset("nested/another-source.js", fixture_path: "mapped"))
   end
 
+  test "resolves prefix on source map filename" do
+    assert_match %r{//# sourceMappingURL=/assets/source.js-[a-z0-9]{40}\.map},
+                 compile_asset(find_asset("prefixed-source.js", fixture_path: "mapped"))
+  end
+
   test "missing source map" do
     assert_no_match %r{sourceMappingURL},
                     compile_asset(find_asset("sourceless.js", fixture_path: "mapped"))