added comments on rnn code #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know what you think about the changes/comments |
haroldw
requested changes
May 31, 2019
| @@ -84,6 +85,7 @@ | |||
| model.embedding.weight.data[UNK_IDX] = torch.zeros(EMBEDDING_DIM) | |||
| model.embedding.weight.data[PAD_IDX] = torch.zeros(EMBEDDING_DIM) | |||
| optimizer = optim.Adam(model.parameters()) | |||
| # Should we use L1Loss or SmoothL1Loss? How do we feel about outliers? | |||
There was a problem hiding this comment.
I did not check in my latest code. Since we decided to frame this as a classification task (negative, neutral, positive), the loss should be CE loss. I didn't realize that my latest code didn't make it in.
There was a problem hiding this comment.
criterion = nn.BCEWithLogitsLoss()
|
@haroldw did you push your latest code? I pulled but didnt see changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.