Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update about-email-notifications.html #3492

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

reitermb
Copy link

@reitermb reitermb commented Feb 25, 2025

Summary of Changes

Adds warning re: potential email downtime
Removes dear colleague banner

Accessible

image
image

Demo here

https://reitermb.github.io/Test/knowledge-center/about-email-notifications.html

Screenshot

image

Copy link

@lhuxraft lhuxraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thank you thank you for this super quick turnaround!!

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.64%. Comparing base (8ffdb0f) to head (d85f262).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3492   +/-   ##
========================================
  Coverage    90.64%   90.64%           
========================================
  Files          310      310           
  Lines         8908     8908           
  Branches       677      677           
========================================
  Hits          8075     8075           
  Misses         704      704           
  Partials       129      129           
Flag Coverage Δ
dev-backend 90.44% <ø> (ø)
dev-frontend 92.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ffdb0f...d85f262. Read the comment docs.

@ADPennington
Copy link
Collaborator

@reitermb could you remove the dear colleague banner in this PR as well? we discussed this afternoon and no longer need it.

@reitermb
Copy link
Author

@reitermb could you remove the dear colleague banner in this PR as well? we discussed this afternoon and no longer need it.

Updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants