-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about-email-notifications.html #3492
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Thank you thank you for this super quick turnaround!!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3492 +/- ##
========================================
Coverage 90.64% 90.64%
========================================
Files 310 310
Lines 8908 8908
Branches 677 677
========================================
Hits 8075 8075
Misses 704 704
Partials 129 129
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
@reitermb could you remove the dear colleague banner in this PR as well? we discussed this afternoon and no longer need it. |
Updated! |
Summary of Changes
Adds warning re: potential email downtime
Removes dear colleague banner
Accessible
Demo here
https://reitermb.github.io/Test/knowledge-center/about-email-notifications.html
Screenshot