-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3294 s3 log file uploader #3487
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3487 +/- ##
===========================================
- Coverage 90.64% 90.52% -0.13%
===========================================
Files 310 311 +1
Lines 8908 8952 +44
Branches 677 680 +3
===========================================
+ Hits 8075 8104 +29
- Misses 704 718 +14
- Partials 129 130 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
I keep getting errors trying to submit a datafile:
Also, where are you creating the bucket in localstack and overriding the default aws region and access/secret keys? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment
Summary of Changes
Provide a brief summary of changes
Pull request closes #3294_
How to Test
List the steps to test the PR
add the following values into your .env file. Please note that I still haven't added these in the docker, so you might have to add these env vars to be able to pull them into docker instance:
Deliverables
More details on how deliverables herein are assessed included here.
Deliverable 1: Accepted Features
Checklist of ACs:
lfrohlich
and/oradpennington
confirmed that ACs are met.Deliverable 2: Tested Code
CodeCov Report
comment in PR)CodeCov Report
comment in PR)Deliverable 3: Properly Styled Code
Deliverable 4: Accessible
iamjolly
andttran-hub
using Accessibility Insights reveal any errors introduced in this PR?Deliverable 5: Deployed
Deliverable 6: Documented
Deliverable 7: Secure
Deliverable 8: User Research
Research product(s) clearly articulate(s):