forked from HHS/TANF-app
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3407 - FRA Reports - submission history #3460
Open
jtimpe
wants to merge
43
commits into
develop
Choose a base branch
from
3407-fra-submission-history
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+391
−39
Open
Changes from 17 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
29ffa76
paginator HOCs
jtimpe 1e7f529
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe a3752f3
implement submission history api
jtimpe 82d0274
use paginator HOC over context
jtimpe a2c3994
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 6634d61
fix file input preview
jtimpe 3a4682a
fix tests
jtimpe 22d5655
add tests
jtimpe eb3427f
rm blank
jtimpe 0385f37
dispatch get after upload
jtimpe 2a65fa9
add file download
jtimpe 1dee1fc
change var name
jtimpe 6040750
datetimes not test-friendly
jtimpe 9379258
unused vars
jtimpe 34a955b
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe a566f99
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 4f1af46
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 0a316c1
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 6df195d
tests
jtimpe 5fc50ef
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 4370b42
fix tests
jtimpe d616e3a
condense column
jtimpe d760ebf
fix download
jtimpe b9941da
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 7d488b8
fix label
jtimpe bc33448
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 897e981
add about/template links
jtimpe 20c7f34
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 788e31a
add page subtitle
jtimpe fb71be0
update explainer table language
jtimpe 3661c37
tests
jtimpe 8f78d5e
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe bf4ec6b
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 9c80f0f
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 08ba02c
fix tests
jtimpe 0f95b01
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 14a15a0
hide download button on upload input error
jtimpe a374b53
download should preserve original file name
jtimpe 6674e7d
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe dc7012b
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe f990af4
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe f5a0662
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe 33c4977
Merge branch '3398-fra-frontend' into 3407-fra-submission-history
jtimpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed if I upload a file, and then select a new file to upload, the download button for the original file upload remains available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another interesting visual bug. Upload and submit a file, click to change the file, cancel the file selector modal, see that the original file and download button are still there. This is different behavior than the data files page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was also able to get the file input element to collapse like the datafiles one. The PR that fixed the issue for the datafiles page merged so you should be able to use the same logic. Note I had to actually expose functions to handle that, it wasn't the removal of our custom css classes completely causing the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good callouts, thank you! i will take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was only able to address your first comment here - hiding the download button when there's a previous upload and an error.
For the second and third comments, i did not experience the same behavior locally. The FRA and DF pages appear to work the same with respect to the original file/download button, and i actually have the input collapse every time i select a file when trying to implement the remove preview logic from the other PR. happy to pair and try to work through it if you're still having issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good on this. I also could not reproduce the second bug I called out. As for the file collapse, Im going to write up a bug ticket for it. The preview logic is a little different than the datafiles page and can't use the exact same solution to prevent the input collapse.