Changes for creating env namspace on the server side and functional test for validating existing keyword with portable resources. #8917

vishwahiremat · 2025-03-19T16:13:09Z

Environment name is only created when env is created using rad env create command and when created using bicep. So added changes to move namespace creation logic to server side.
Added functional tests to validate the existing keyword with portable resources.

Description

Please explain the changes you've made.

Type of change

This pull request fixes a bug in Radius and has an approved issue (issue link required).
This pull request adds or changes features of Radius and has an approved issue (issue link required).
This pull request is a minor refactor, code cleanup, test improvement, or other maintenance task and doesn't change the functionality of Radius (issue link optional).

Fixes: #8464

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

An overview of proposed schema changes is included in a linked GitHub issue.
- Yes
- Not applicable
A design document PR is created in the design-notes repository, if new APIs are being introduced.
- Yes
- Not applicable
The design document has been reviewed and approved by Radius maintainers/approvers.
- Yes
- Not applicable
A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
- Yes
- Not applicable
A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
- Yes
- Not applicable
A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
- Yes
- Not applicable

…alidating existing capability with portable resources Signed-off-by: Vishwanath Hiremath <[email protected]>

codecov · 2025-03-19T16:27:21Z

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 55.72%. Comparing base (207b9f7) to head (56f274d).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...ntroller/environments/createorupdateenvironment.go	66.66%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8917      +/-   ##
==========================================
+ Coverage   55.65%   55.72%   +0.06%     
==========================================
  Files         599      602       +3     
  Lines       40750    41176     +426     
==========================================
+ Hits        22681    22944     +263     
- Misses      16351    16479     +128     
- Partials     1718     1753      +35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Vishwanath Hiremath <[email protected]>

radius-functional-tests · 2025-03-20T18:53:37Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`d86b76e`
Unique ID	funcecf4e269e5
Image tag	pr-funcecf4e269e5

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcecf4e269e5
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcecf4e269e5
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcecf4e269e5
controller test image location: ghcr.io/radius-project/dev/controller:pr-funcecf4e269e5
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcecf4e269e5
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: Vishwanath Hiremath <[email protected]>

radius-functional-tests · 2025-03-20T19:51:42Z

Radius functional test overview

🔍 Go to test action run

Name	Value
Repository	vishwahiremat/radius
Commit ref	`d278eab`
Unique ID	func6c16e31b86
Image tag	pr-func6c16e31b86

Click here to see the list of tools in the current test run

gotestsum 1.12.0
KinD: v0.20.0
Dapr:
Azure KeyVault CSI driver: 1.4.2
Azure Workload identity webhook: 1.3.0
Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6c16e31b86
Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6c16e31b86
dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6c16e31b86
controller test image location: ghcr.io/radius-project/dev/controller:pr-func6c16e31b86
ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6c16e31b86
deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

Signed-off-by: Vishwanath Hiremath <[email protected]>

ytimocin · 2025-03-20T21:31:11Z

Have you checked this issue @vishwahiremat? I was running into an issue where namespace wasn't being created during rad deploy env.bicep.

vishwahiremat · 2025-03-20T21:34:51Z

Have you checked this issue @vishwahiremat? I was running into an issue where namespace wasn't being created during rad deploy env.bicep.

this PR will fix this issue, it will create a kubernetes namespace for the environment when env is created using bicep file.

ytimocin

We need to add namespace check to functional and unit tests. Bicep file name also needs to be changed.

test/functional-portable/datastoresrp/noncloud/resources/mongodb_test.go

ytimocin · 2025-03-21T13:28:05Z

test/functional-portable/datastoresrp/noncloud/resources/mongodb_test.go

@@ -114,3 +114,58 @@ func Test_MongoDB_Recipe(t *testing.T) {

 	test.Test(t)
 }
+
+func Test_MongoDB_Recipe_Existing(t *testing.T) {


Where do we test that the namespace exists? Can we also use a better (more specific) naming for the test?

ytimocin · 2025-03-21T13:28:40Z

...atastoresrp/noncloud/resources/testdata/datastoresrp-resources-mongodb-recipe-exsiting.bicep

Name needs to be changed.

updated the name

ytimocin · 2025-03-21T13:30:23Z

pkg/corerp/frontend/controller/environments/createorupdateenvironment_test.go

Where did we add the namespace check to the tests?

added the check for namespace in the unit tests

Signed-off-by: Vishwanath Hiremath <[email protected]>

test/functional-portable/datastoresrp/noncloud/resources/mongodb_test.go

Signed-off-by: Vishwanath Hiremath <[email protected]>

move creatinv env namespace to server side, and adding e2e test for v…

Loading
Loading status checks…

336e6e7

…alidating existing capability with portable resources Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 19, 2025 16:14 — with GitHub Actions Inactive

fix e2e test

Loading
Loading status checks…

7606314

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 19, 2025 22:09 — with GitHub Actions Inactive

delete validating namespace in cli code

Loading
Loading status checks…

cbc086d

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 18:38 — with GitHub Actions Inactive

vishwahiremat added 2 commits March 20, 2025 11:44

Merge branch 'main' into vishwahiremat/fixCreatingEnvScopedResources

dbf8561

Signed-off-by: Vishwanath Hiremath <[email protected]>

merge

Loading
Loading status checks…

7522f67

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 18:47 — with GitHub Actions Inactive

fix typo

Loading
Loading status checks…

a88ea31

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 18:50 — with GitHub Actions Inactive

typo fic

Loading
Loading status checks…

d86b76e

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to functional-tests March 20, 2025 18:52 — with GitHub Actions Inactive

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 18:52 — with GitHub Actions Inactive

fix unit tests

Loading
Loading status checks…

09ecb71

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 19:26 — with GitHub Actions Inactive

fix linting erros

Loading
Loading status checks…

d278eab

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 19:36 — with GitHub Actions Inactive

vishwahiremat temporarily deployed to functional-tests March 20, 2025 19:50 — with GitHub Actions Inactive

vishwahiremat marked this pull request as ready for review March 20, 2025 20:52

vishwahiremat requested review from a team as code owners March 20, 2025 20:52

adding a new recipe for the new e2e test

Loading
Loading status checks…

be4d667

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 20, 2025 21:04 — with GitHub Actions Inactive

ytimocin requested changes Mar 21, 2025

View reviewed changes

Merge branch 'main' into vishwahiremat/fixCreatingEnvScopedResources

Loading
Loading status checks…

d68bf79

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 18:34 — with GitHub Actions Inactive

adding comments to the functional test

Loading
Loading status checks…

d764bbf

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 18:48 — with GitHub Actions Inactive

kachawla previously approved these changes Mar 26, 2025

View reviewed changes

test/functional-portable/datastoresrp/noncloud/resources/mongodb_test.go Outdated Show resolved Hide resolved

adding env to parameters

Loading
Loading status checks…

983a9d8

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat dismissed kachawla’s stale review via 983a9d8 March 26, 2025 20:41

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 20:41 — with GitHub Actions Inactive

updating the env

Loading
Loading status checks…

634f88c

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 21:03 — with GitHub Actions Inactive

test

Loading
Loading status checks…

0d950f5

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 21:32 — with GitHub Actions Inactive

test

Loading
Loading status checks…

aabdc22

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 22:45 — with GitHub Actions Inactive

test

Loading
Loading status checks…

de81e60

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 23:10 — with GitHub Actions Inactive

test

Loading
Loading status checks…

1d63108

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 26, 2025 23:24 — with GitHub Actions Inactive

test

Loading
Loading status checks…

6f5b590

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 27, 2025 00:02 — with GitHub Actions Inactive

test

Loading
Loading status checks…

13b7387

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 27, 2025 05:01 — with GitHub Actions Inactive

test

Loading
Loading status checks…

b87656a

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 27, 2025 06:05 — with GitHub Actions Inactive

test

Loading
Loading status checks…

5f8c4a0

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep March 27, 2025 06:17 — with GitHub Actions Inactive

test

Loading
Loading status checks…

af1cd2b

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep April 1, 2025 18:54 — with GitHub Actions Inactive

test

Loading
Loading status checks…

56f274d

Signed-off-by: Vishwanath Hiremath <[email protected]>

vishwahiremat temporarily deployed to publish-bicep April 1, 2025 20:30 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes for creating env namspace on the server side and functional test for validating existing keyword with portable resources. #8917

Changes for creating env namspace on the server side and functional test for validating existing keyword with portable resources. #8917

vishwahiremat commented Mar 19, 2025 •

edited by ytimocin

Loading

codecov bot commented Mar 19, 2025 •

edited

Loading

radius-functional-tests bot commented Mar 20, 2025 •

edited

Loading

radius-functional-tests bot commented Mar 20, 2025 •

edited

Loading

ytimocin commented Mar 20, 2025

vishwahiremat commented Mar 20, 2025 •

edited

Loading

ytimocin left a comment

ytimocin Mar 21, 2025

ytimocin Mar 21, 2025

vishwahiremat Mar 24, 2025

ytimocin Mar 21, 2025

vishwahiremat Mar 24, 2025

Changes for creating env namspace on the server side and functional test for validating existing keyword with portable resources. #8917

Are you sure you want to change the base?

Changes for creating env namspace on the server side and functional test for validating existing keyword with portable resources. #8917

Conversation

vishwahiremat commented Mar 19, 2025 • edited by ytimocin Loading

Description

Type of change

Contributor checklist

codecov bot commented Mar 19, 2025 • edited Loading

Codecov Report

radius-functional-tests bot commented Mar 20, 2025 • edited Loading

Radius functional test overview

Test Status

radius-functional-tests bot commented Mar 20, 2025 • edited Loading

Radius functional test overview

Test Status

ytimocin commented Mar 20, 2025

vishwahiremat commented Mar 20, 2025 • edited Loading

ytimocin left a comment

Choose a reason for hiding this comment

ytimocin Mar 21, 2025

Choose a reason for hiding this comment

ytimocin Mar 21, 2025

Choose a reason for hiding this comment

vishwahiremat Mar 24, 2025

Choose a reason for hiding this comment

ytimocin Mar 21, 2025

Choose a reason for hiding this comment

vishwahiremat Mar 24, 2025

Choose a reason for hiding this comment

vishwahiremat commented Mar 19, 2025 •

edited by ytimocin

Loading

codecov bot commented Mar 19, 2025 •

edited

Loading

radius-functional-tests bot commented Mar 20, 2025 •

edited

Loading

radius-functional-tests bot commented Mar 20, 2025 •

edited

Loading

vishwahiremat commented Mar 20, 2025 •

edited

Loading