Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Resyntax fixes #482

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Automated Resyntax fixes #482

wants to merge 13 commits into from

Conversation

resyntax-ci[bot]
Copy link
Contributor

@resyntax-ci resyntax-ci bot commented Feb 12, 2025

Resyntax fixed 20 issues in 10 files.

  • Fixed 4 occurrences of if-begin-to-cond
  • Fixed 3 occurrences of map-to-for
  • Fixed 2 occurrences of quasiquote-to-list
  • Fixed 2 occurrences of when-expression-in-for-loop-to-when-keyword
  • Fixed 1 occurrence of if-let-to-cond
  • Fixed 1 occurrence of ormap-to-for/or
  • Fixed 1 occurrence of or-hash-ref-set!-to-hash-ref!
  • Fixed 1 occurrence of if-else-false-to-and
  • Fixed 1 occurrence of let-to-define
  • Fixed 1 occurrence of define-let-to-double-define
  • Fixed 1 occurrence of always-throwing-if-to-when
  • Fixed 1 occurrence of quasiquote-to-append
  • Fixed 1 occurrence of inline-unnecessary-begin

resyntax-ci bot added 13 commits February 12, 2025 00:15
This quasiquotation is equialent to a simple `list` call.
This `if` expression can be refactored to an equivalent expression using `and`.
This `let` expression can be pulled up into a `define` expression.
This `map` operation can be replaced with a `for/list` loop.
Using `cond` instead of `if` here makes `begin` unnecessary
This expression can be replaced with a simpler, equivalent `hash-ref!` expression.
This `begin` form can be flattened into the surrounding definition context.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
This quasiquotation is equialent to calling `append`.
Using `when` and `unless` is simpler than a conditional with an always-throwing branch.
This `ormap` operation can be replaced with a `for/or` loop.
Use the `#:when` keyword instead of `when` to reduce loop body indentation.
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants