Fix very rare deadlock #1771
Merged
Fix very rare deadlock #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1751
branch
from
b2025e2 to
3fff3aa
Compare
Fixes #1751 * Drain and log pending work when AsyncConsumerDispatcher loop ends. * Make quiescing thread safe. * Ensure that dequeued RPC continuations are always disposed. Found by @DenisMayorko ⭐
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1751
branch
from
5da1089 to
2718d46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751
Attempt to fix deadlock by waiting on channel dispatcher first, then channel reader.