Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Named beans #46140

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Named beans #46140

wants to merge 2 commits into from
+32 −1

Conversation

mcruzdev
Copy link
Contributor

@mcruzdev mcruzdev commented Feb 7, 2025

Fixes #45961

@quarkus-bot quarkus-bot bot added the area/spring Issues relating to the Spring integration label Feb 7, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 0ec3525.

Failing Jobs

Status Name Step Failures Logs Raw logs Build scan
✔️ JVM Tests - JDK 17 Logs Raw logs 🔍
✔️ JVM Tests - JDK 21 Logs Raw logs 🔍
✖ JVM Tests - JDK 17 Windows Clean Gradle temp directory ⚠️ Check → Logs Raw logs 🔍

You can consult the Develocity build scans.

@geoand geoand requested a review from mkouba February 7, 2025 15:04
mkouba
mkouba reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@mkouba mkouba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks reasonable but I did not check the other parts of the SpringDIProcessor and how exactly we map spring annotations to @Named...

Also pls squash the commits and maybe add a more "informative" commit description.

@mcruzdev
Copy link
Contributor Author

mcruzdev commented Feb 7, 2025

Yes @mkouba I will do it. It had to be a draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkouba mkouba mkouba left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quarkus-spring-di: @Bean("foo") is not transformed into the proper @Named("foo") annotation
2 participants
@mcruzdev @mkouba