Once-a-while grammar and style review for the Datasource guide #46128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/docstyle
This comment has been minimized.
This comment has been minimized.
|
🙈 The PR is closed and the preview is expired. |
rolfedh
reviewed
Feb 6, 2025
yrodiere
reviewed
Feb 10, 2025
Signed-off-by: Michal Maléř <[email protected]>
Signed-off-by: Michal Maléř <[email protected]>
Signed-off-by: Michal Maléř <[email protected]>
MichalMaler
force-pushed
the
datasource-reveiw
branch
from
60c3753 to
0658918
Compare
Status for workflow
|
yrodiere
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grammar and style review before the
3.20will be forked.I am kindly asking @yrodiere and @jmartisk for a review since it is highly possible that some of my changes can change the meaning or just be further enhanced to provide more value. Thank you!