Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS: Add downstream-relevant attributes to facilitate single sourcing #45962

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

DOCS: Add downstream-relevant attributes to facilitate single sourcing #45962

wants to merge 3 commits into from
+10 −0

Conversation

sheilamjones
Copy link
Contributor

@sheilamjones sheilamjones commented Jan 29, 2025 •
edited
Loading

This PR aims to update the upstream _attributes.adoc file with the additional attributes needed to migrate the Red Hat Deploying to OpenShift Container Platform guide to the upstream Quarkus community and to facilitate the single-sourcing of the guide back downstream.

For more information, see QDOCS-1082

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 29, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/docstyle issues related for manual docstyle review area/documentation labels Jan 29, 2025
@sheilamjones sheilamjones self-assigned this Jan 29, 2025
@sheilamjones sheilamjones changed the title [DOCS]: Add downstream-relevant attributes to facilitate single sourcing DOCS: Add downstream-relevant attributes to facilitate single sourcing Jan 29, 2025
@sheilamjones
Copy link
Contributor Author

Hi @gsmet, @rolfedh, @iocanel,
To migrate the Deploy to OpenShift guide from downstream to upstream, I need to add additional attributes to the upstream _attributes.adoc file. This will help facilitate the migration of the content from downstream to upstream and to single source this content back downstream for RHBQ 3.20.
Kind regards,
Sheila

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 29, 2025 •
edited
Loading

🎊 PR Preview 2840192 has been successfully built and deployed to https://quarkus-pr-main-45962-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
rolfedh
rolfedh reviewed Feb 3, 2025
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with gsmet's suggestions. Otherwise, everything looks good to me.

iocanel
iocanel requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the changes requested by @gsmet

@sheilamjones sheilamjones force-pushed the QDOCS-1082-attributes branch from 0c06f41 to f411b57 Compare February 4, 2025 14:26
sheilamjones
sheilamjones commented Feb 4, 2025
View reviewed changes
Copy link
Contributor Author

@sheilamjones sheilamjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iocanel. I have now implemented these fixes.

@sheilamjones sheilamjones requested a review from iocanel February 4, 2025 14:30
@sheilamjones
Copy link
Contributor Author

Hi @gsmet, @iocanel, @rolfedh,
Fix is implemented per your feedback. If all looks okay now, this PR is ready to merge.
Kind regards,
Sheila

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
iocanel
iocanel approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@iocanel iocanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rolfedh
rolfedh approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sheilamjones sheilamjones force-pushed the QDOCS-1082-attributes branch from f411b57 to 609a6e6 Compare February 7, 2025 15:47
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 609a6e6.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sheilamjones sheilamjones requested a review from gsmet February 7, 2025 16:33
@sheilamjones
Copy link
Contributor Author

Hi @gsmet, @iocanel, @rolfedh,
Thanks all for your reviews and approval. This PR is ready to merge.
Kind regards,
Sheila

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfedh rolfedh rolfedh approved these changes

@iocanel iocanel iocanel approved these changes

@gsmet gsmet Awaiting requested review from gsmet

Assignees

@sheilamjones sheilamjones

Labels
area/docstyle issues related for manual docstyle review area/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sheilamjones @rolfedh @iocanel @gsmet