Fix #6764: Optimizer failure #6977
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cifrzak
force-pushed
the
main
branch
2 times, most recently
from
776ddcf to
053e32f
Compare
cifrzak
force-pushed
the
main
branch
2 times, most recently
from
039ce9a to
a441961
Compare
| super().__init__(exponent=exponent, global_shift=global_shift) | ||
| if global_shift <= -2.0 or global_shift >= 2.0: | ||
| raise ValueError( | ||
| f"Gate global shift must be in the range (-2,2). Invalid Value: {global_shift}" |
There was a problem hiding this comment.
This introduces a backwards incompatibility, as initialization of larger values will fail now.
Wouldn't it be better to normalize the global_shift rather than fail?
Also, should this behavior be consistent for all the pow gates?
There was a problem hiding this comment.
#7057 will fix this in a consistent and backwards-compatible way.
|
Will be solved with #7057 |
Fix #6764
Add global_shift parameter validation in eigen gate init plus test.
Range is currently set to (-2,2), though issue comment mentions [0,2).
Also another comment mentions the value could be symbolic, but the current code seems to expect plain float only.