-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Logging and Commenting #1634
base: main
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
@@ -233,7 +233,7 @@ def get_log_context(body, event, action, build_number): | |||
"request_id": uuid.uuid4().hex, "build_number": build_number, "app_name": app_name, | |||
"repo": repo, "git_org": git_org, "installation_id": installation_id} | |||
except Exception as e: | |||
get_logger().error("Failed to get log context", e) | |||
get_logger().error(f"Failed to get log context: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unsafe. if 'e' is a dictionary (and it can happen), it will crash
->
get_logger().error(f"Failed to get log context", artifact={'error': e}
thanks @ishaansehgal99 |
User description
Fixed identation added logs.
PR Type
Bug fix, Enhancement
Description
Fixed indentation issues in multiple function calls.
Enhanced logging messages for better debugging.
Added debug logs for request handling and filtering.
Improved error logging with detailed exception messages.
Changes walkthrough 📝
github_app.py
Fix indentation and enhance logging functionality
pr_agent/servers/github_app.py
_perform_auto_commands_github
calls.get_log_context
.