Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add web page UI on the root URL #43

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Add web page UI on the root URL #43

merged 14 commits into from
Nov 9, 2023

Conversation

Xpirix
Copy link
Collaborator

@Xpirix Xpirix commented Oct 31, 2023 •
edited
Loading

@Xpirix Xpirix marked this pull request as ready for review November 2, 2023 07:13
@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 3, 2023 •
edited
Loading

@dimasciput , according to our meeting, please find below the changes that I made:

  • Align the page title to the left and logo to the right.
  • Allow submitting blank URL (Url not required).
  • Add a save button to form review step.

Edit: I've added also the note before publishing.

Feel free to ask if you have any suggestions.

@Xpirix
Copy link
Collaborator Author

Xpirix commented Nov 8, 2023

Hi @dimasciput , could you review these changes please?

@dimasciput dimasciput merged commit b5afb63 into qgis:master Nov 9, 2023
2 checks passed
@Xpirix Xpirix deleted the root_web_page branch November 17, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimasciput dimasciput dimasciput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xpirix @dimasciput